fix: handle notifications/cancelled for valid request ID 0#2502
Open
nankingjing wants to merge 2 commits into
Open
fix: handle notifications/cancelled for valid request ID 0#2502nankingjing wants to merge 2 commits into
nankingjing wants to merge 2 commits into
Conversation
JSON-RPC allows 0 as a valid request id, but Protocol._oncancel used a truthiness check on params.requestId, so a cancellation targeting request id 0 was silently dropped and the in-flight handler kept running. Replace the truthiness check with an explicit undefined check. Fixes modelcontextprotocol#2283
🦋 Changeset detectedLatest commit: 7078a15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2283
JSON-RPC allows request ID 0 as a valid identifier, but the SDK's cancelled notification handler treats it as falsy and silently drops the cancellation. This means agent orchestrators cannot cancel tool calls numbered with ID 0.
Fix: Replace truthiness check with explicit undefined check so that
0is treated as a valid request ID for cancellation.Changes:
packages/core-internal/src/shared/protocol.ts: Change!notification.params.requestIdtonotification.params.requestId === undefinedin_oncancelpackages/core-internal/test/shared/protocol.test.ts: Add test verifying cancellation works for request ID 0